Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in order of properties #158

Merged
merged 18 commits into from
Nov 8, 2023
Merged

Consistency in order of properties #158

merged 18 commits into from
Nov 8, 2023

Conversation

dhendryc
Copy link
Collaborator

@dhendryc dhendryc commented Nov 6, 2023

The order of properties should be consisted with signatures of the functions.

src/managed_blmo.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ee5cc6c) 86.23% compared to head (a72f597) 86.43%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   86.23%   86.43%   +0.20%     
==========================================
  Files          17       17              
  Lines        1482     1482              
==========================================
+ Hits         1278     1281       +3     
+ Misses        204      201       -3     
Files Coverage Δ
src/managed_blmo.jl 75.55% <100.00%> (ø)
src/node.jl 91.84% <100.00%> (+1.06%) ⬆️
src/interface.jl 94.83% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhendryc
Copy link
Collaborator Author

dhendryc commented Nov 7, 2023

Disabled the CI Test on Mac with Julia 1.6.

We had an issue with HiGHS that we could not track down. The instance was running fine on Ubuntu and Windows with Julia 1.9 and Julia 1.6 and Mac with Julia 1.9.

@matbesancon matbesancon closed this Nov 7, 2023
@matbesancon matbesancon reopened this Nov 7, 2023
@dhendryc dhendryc merged commit be4562f into main Nov 8, 2023
5 of 8 checks passed
@dhendryc dhendryc deleted the clean-managed branch November 8, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants